Skip to content

Remove readonly property from id, name, type#3413

Closed
allencal wants to merge 1 commit intoAzure:masterfrom
allencal:master
Closed

Remove readonly property from id, name, type#3413
allencal wants to merge 1 commit intoAzure:masterfrom
allencal:master

Conversation

@allencal
Copy link
Contributor

@allencal allencal commented Jul 13, 2018 •
edited
Loading

Some established TrafficManager operations expect these resource values to be set.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@allencal
Remove readonly property from id, name, type
3064fb7 
Some established TrafficManager operations expect these resource values to be set.
@AutorestCI AutorestCI mentioned this pull request Jul 13, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Jul 13, 2018 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#2899

@AutorestCI
Copy link

AutorestCI commented Jul 13, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@azuresdkci azuresdkci requested a review from jianghaolu July 13, 2018 17:21
@AutorestCI AutorestCI mentioned this pull request Jul 13, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Jul 13, 2018 •
edited
Loading

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#2829

@AutorestCI AutorestCI mentioned this pull request Jul 13, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Jul 13, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-ruby#1461

@AutorestCI
Copy link

AutorestCI commented Jul 13, 2018 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@jianghaolu jianghaolu added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 16, 2018
@jianghaolu
Copy link
Contributor

jianghaolu commented Jul 16, 2018

@ravbhatnagar I don't think these properties are allowed to be set in ARM? Please help clarify, thanks!

@ravbhatnagar
Copy link
Contributor

ravbhatnagar commented Jul 23, 2018

yes these have to be read-only.

@azuresdkci
Copy link
Contributor

azuresdkci commented Aug 2, 2018

Can one of the admins verify this patch?

@jianghaolu jianghaolu closed this Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jianghaolu jianghaolu Awaiting requested review from jianghaolu

Assignees

@jianghaolu jianghaolu

Labels

WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@allencal @AutorestCI @jianghaolu @ravbhatnagar @azuresdkci